Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await asyncio.ensure_future #860

Merged
merged 1 commit into from
Oct 11, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions kubespawner/spawner.py
Original file line number Diff line number Diff line change
Expand Up @@ -2802,7 +2802,7 @@ async def catch_reflector_start(func):

if previous_reflector:
# we replaced the reflector, stop the old one
asyncio.ensure_future(previous_reflector.stop())
await asyncio.ensure_future(previous_reflector.stop())

# wait for first load
await current_reflector.first_load_future
Expand Down Expand Up @@ -3254,7 +3254,7 @@ async def _start(self):
ref_key,
)
self.log.error("Pods: %s", sorted(self.pod_reflector.pods.keys()))
asyncio.ensure_future(self._start_watching_pods(replace=True))
await asyncio.ensure_future(self._start_watching_pods(replace=True))
raise

pod = self.pod_reflector.pods[ref_key]
Expand Down Expand Up @@ -3379,7 +3379,7 @@ async def stop(self, now=False):
self.log.error(
"Pod %s did not disappear, restarting pod reflector", ref_key
)
asyncio.ensure_future(self._start_watching_pods(replace=True))
await asyncio.ensure_future(self._start_watching_pods(replace=True))
raise

@default('env_keep')
Expand Down