Skip to content

Commit

Permalink
Fix detail in testing bind_dn_template
Browse files Browse the repository at this point in the history
`lookup_dn` needs to be True here, because the `{username}` expansion in the `bind_dn_template` string will without it expand to fry as a login name, but needs to be expanded to `Philip J. Fry` as that is the `fry` user's cn attribute, and only such expanded dn template will successfully be found.
  • Loading branch information
consideRatio authored Oct 31, 2024
1 parent 11bf300 commit 3782518
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion ldapauthenticator/tests/test_ldapauthenticator.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ async def test_ldap_auth_disallowed(c):
)
async def test_ldap_auth_bind_dn_template(c, bind_dn_template):
c.LDAPAuthenticator.bind_dn_template = bind_dn_template
c.LDAPAuthenticator.lookup_dn = False
authenticator = LDAPAuthenticator(config=c)

# proper username and password in allowed group
Expand Down

0 comments on commit 3782518

Please sign in to comment.