Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello !
Thank you for the work done on this plugin ! I am currently using it for accessing JupyterHub in our data science team at my company, but I needed to add an option "use_tls" and set it to False to actually make it work. That is because we need to connect to a LDAP server that needs this configuration.
For information, such option exists in the LDAP connector used by Airflow, another tool that we are also using. There is distincts "USE_SSL" and "USE_TLS" options for addressing our use case, so I just applied the same logic.
I hope that my PR is correct, I simply added the option "use_tls" and a small test for testing the option. I also needed to update the black pre-commit hook because it didn't work on my computer.
Obviously, the default value of this option does not change anything on the current behavior.
Thank you !