Link generator handles non-git sources #195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-morris
force-pushed
the
gh-pages-non-git
branch
4 times, most recently
from
74acab7
to
0886c68
Compare
2 tasks
The link generator creates gitpuller links for non-git sources including archives from google drive, dropbox and any publicly accessible web URL. In order to handle a non- git source correctly in nbgitpuller, we added the provider parameter to the URL string. Other Changes: - if git is the source, the branch parameter is always included on the URL and defaults to 'main' if none is provided. This should then allow users that have not upgraded their nbgitpuller version to still work. - All sources(git and non-git) can handle a path to a particular folder or notebook. I had taken this ability away from non-git sources in earlier versions.
sean-morris
force-pushed
the
gh-pages-non-git
branch
from
433b72c
to
eefdbfd
Compare
We renamed the nbgitpuller-standard-web downloader to nbgitpuller-generic-web. This commit reflects this change in the link generator.
This syncs the changes made in nbgitpuller app
- Changed "source" to "content-provider" in both files - In link.html, added detail to regEx for URL patterns - removed circleci folder I thought was needed - In generateBinderUrl, clarified the parameter names to reflect envRepoX and contentRepoX and fixed the generatation of the URL - In binder tab, the environment repo now includes the branch if not specified - added documentation - cleaned up the generation of the URLPath
Co-authored-by: Erik Sundell <[email protected]>
|
My spacing is off. I will check that out. What is the standard here? |
I think 2 for html files, 4 for python, and 4 for js files. That seems to be the spacing of choice in this repo, it will always be 4 for python files across the JuptyerHub organization, but I'm not sure there is a well defined standard for js/html files, so then I'm just now making sure the code stays consistent within files and between files in the repo. |
Co-authored-by: Erik Sundell <[email protected]>
- removed duplicate data-X on nav bar button - removed duplicate id on the source repo button and download button
…itpuller into gh-pages-non-git
sean-morris
force-pushed
the
gh-pages-non-git
branch
from
d973cc4
to
4aafa3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link generator creates gitpuller links for non-git
sources including archives from google drive, dropbox
and any publicly accessible web url.