Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dev script #88

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Improve dev script #88

merged 3 commits into from
Oct 11, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Oct 11, 2024

Fixes #64 by creating a dev-install command(s) in package.json files.

These command install the python package in dev mode, and the labextension in develop.

The PR also rename install.sh script to dev-install.sh for consistency.

Note

I intentionally not added the dev-uninstall command, which leads to unstable installation, the symlinks not being removed.

Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/improve_dev_script

@brichet brichet added the maintenance Packaging, tests label Oct 11, 2024
@brichet brichet marked this pull request as ready for review October 11, 2024 11:17
@brichet brichet requested a review from jtpio October 11, 2024 11:17
Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Maybe a follow-up improvement could be to try support developing on windows? To be more welcoming to new contributors who may be using Windows.

Not sure the bash script would run as is on Windows at the moment.

@jtpio jtpio merged commit ec16bcf into jupyterlab:main Oct 11, 2024
12 of 13 checks passed
@jtpio
Copy link
Member

jtpio commented Oct 11, 2024

Maybe a follow-up improvement could be to try support developing on windows? To be more welcoming to new contributors who may be using Windows.

For now one can use the npm scripts directly so maybe it's enough.

@brichet
Copy link
Collaborator Author

brichet commented Oct 11, 2024

Not sure the bash script would run as is on Windows at the moment.

Right, maybe using a python script instead of bash would do it.

@brichet brichet deleted the improve_dev_script branch October 11, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Packaging, tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve the dev-install script
2 participants