Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Jupyter Collaboration 3 #94

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Oct 29, 2024

Update dependencies:

  • jupyter_collaboration >= 3 (python and javascript)
  • @jupyter/ydoc>2 (javascript)

@brichet brichet added the maintenance Packaging, tests label Oct 29, 2024
Copy link
Contributor

Binder 👈 Launch a Binder on branch brichet/jupyter-chat/upgrade-collaboration-3

@brichet brichet force-pushed the upgrade-collaboration-3 branch 2 times, most recently from 7c301d4 to 56deef5 Compare November 8, 2024 15:05
@brichet brichet force-pushed the upgrade-collaboration-3 branch 2 times, most recently from ee710a7 to 74dbfe5 Compare November 25, 2024 12:06
@dlqqq
Copy link
Member

dlqqq commented Dec 4, 2024

Motivation for this change (authored by @brichet in a private conversation):

It is related to jupyterlab/jupyter-collaboration#379, that should be in soon, and adds a widget to display the current users of a collaborative document.
IIRC this PR can't be backported to jupyter-collaboration 2 because of its dependencies to jupyter/ydoc .

@brichet brichet force-pushed the upgrade-collaboration-3 branch from 74dbfe5 to f8b51be Compare December 9, 2024 15:43
@dlqqq dlqqq changed the title Update to jupyter collaboration 3 Upgrade to Jupyter Collaboration 3 Dec 9, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brichet Thank you for working on this while I was away! Left a few points of feedback below.

packages/jupyterlab-chat/package.json Show resolved Hide resolved
packages/jupyterlab-chat/src/ychat.ts Show resolved Hide resolved
packages/jupyterlab-chat/src/ychat.ts Show resolved Hide resolved
@dlqqq
Copy link
Member

dlqqq commented Dec 18, 2024

BTW you may have to close & re-open this PR to re-run the workflows. I noticed the readthedocs workflows stalled for PRs opened last week, but the issue should be fixed now.

@brichet
Copy link
Collaborator Author

brichet commented Dec 18, 2024

Bump CI

@brichet brichet closed this Dec 18, 2024
@brichet brichet reopened this Dec 18, 2024
Copy link
Member

@dlqqq dlqqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, TY for answering my feedback so thoughtfully!

@dlqqq dlqqq force-pushed the upgrade-collaboration-3 branch from c5b2a10 to 470dc21 Compare December 18, 2024 16:36
@brichet brichet force-pushed the upgrade-collaboration-3 branch from 470dc21 to 3db329f Compare December 18, 2024 18:11
@brichet brichet merged commit 5a0d0cd into jupyterlab:main Dec 19, 2024
11 checks passed
@brichet brichet deleted the upgrade-collaboration-3 branch December 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Packaging, tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants