-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Jupyter Collaboration 3 #94
Conversation
7c301d4
to
56deef5
Compare
ee710a7
to
74dbfe5
Compare
Motivation for this change (authored by @brichet in a private conversation): It is related to jupyterlab/jupyter-collaboration#379, that should be in soon, and adds a widget to display the current users of a collaborative document. |
74dbfe5
to
f8b51be
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@brichet Thank you for working on this while I was away! Left a few points of feedback below.
BTW you may have to close & re-open this PR to re-run the workflows. I noticed the readthedocs workflows stalled for PRs opened last week, but the issue should be fixed now. |
Bump CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, TY for answering my feedback so thoughtfully!
c5b2a10
to
470dc21
Compare
470dc21
to
3db329f
Compare
Update dependencies:
jupyter_collaboration >= 3
(python and javascript)@jupyter/ydoc>2
(javascript)