Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin sphinx #85

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Unpin sphinx #85

merged 3 commits into from
Feb 3, 2023

Conversation

lesteve
Copy link
Contributor

@lesteve lesteve commented Feb 3, 2023

fix #83
close #84

@lesteve
Copy link
Contributor Author

lesteve commented Feb 3, 2023

Trying to work-around the conda conflict issue in the CI which is likely related to conda-incubator/setup-miniconda#274

I took inspiration from https://github.com/robotology/ycm/pull/426/files.

@@ -182,7 +182,6 @@ def run(self):


class _LiteDirective(SphinxDirective):

Copy link
Contributor Author

@lesteve lesteve Feb 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow latest black says there should be no newline here. This was the reason this CI build failed

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@martinRenou martinRenou merged commit 29a65cc into jupyterlite:main Feb 3, 2023
@lesteve lesteve deleted the unpin-sphinx branch February 3, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release the pin on Sphinx version ?
2 participants