-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register all kernels in one plugin #107
base: main
Are you sure you want to change the base?
Conversation
12777c0
to
59a876b
Compare
broadcastChannel?: IBroadcastChannelWrapper | ||
) => { | ||
const kernelPlugin: JupyterLiteServerPlugin<void> = { | ||
id: '@jupyterlite/xeus-kernel:register', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like having a single plugin would prevent disabling some kernels via disabledExtensions
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can keep the current behavior by checking for the PageConfig.disabledExtensions
value in the activation function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason we need synchronous XHR is to generate JupyterLab plugins dynamically from the fetch data. Which I do not feel is necessary since these plugins do not provide any token. If it's just about to disable some kernels later, we can have other mechanisms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, it would be great to remove this synchronous XHR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need the ability to disable kernels?
If users don't want a kernel in the UI, their solution is to not install it in the provided environment.yml
file.
Closes #106