Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bootstrap environments using mambajs, allowing libraries handling for other kernels than xeus-python #130

Merged
merged 11 commits into from
Dec 17, 2024
Merged

Bootstrap environments using mambajs, allowing libraries handling for other kernels than xeus-python #130

merged 11 commits into from
Dec 17, 2024

Conversation

AnastasiaSliusar
Copy link
Contributor

The PR uses mambajs for downloading and saving conda packages for a kernel if it is not xeus-python kernel

martinRenou
martinRenou requested changes Dec 13, 2024
View reviewed changes
src/worker.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou mentioned this pull request Dec 13, 2024
Merged
@martinRenou
Publish 3.0.0a0
22a94fb 
SHA256 hashes:

jupyterlite-xeus-2.1.2.tgz: 7b4c609535e58427961dcd91f4f17f1f1772d2e5138d269a2eb731269169f0ad

jupyterlite-xeus-extension-2.1.2.tgz: 75a9bc44d1692f89d7cf66d4868c3c801e4a4fd7917079dd8e13e4fb8d67a76d

jupyterlite_xeus-3.0.0a0-py3-none-any.whl: 0e7bde6fcf00d7645180bd24e442f1d8e154ede9a79bdc28e6be050259b29b50

jupyterlite_xeus-3.0.0a0.tar.gz: 6b145833b74eaaf194a0dddd6e67d10c2e7b7e722217165e514aee6e8a34946f
@martinRenou
Make use of mambajs
77546cd 
Author: Anastasia Sliusar <[email protected]>
@martinRenou
Copy link
Member

Damn I made a mistake sorry

@martinRenou
Copy link
Member

Reviving it through AnastasiaSliusar#3 with conflicts resolved

@martinRenou martinRenou reopened this Dec 13, 2024
martinRenou
martinRenou requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That works nicely. I just have a couple of nitpicky comments, also can you run the linters with jlpm run lint && jlpm run prettier and commit the changes?

packages/xeus/src/worker.ts Outdated Show resolved Hide resolved
packages/xeus/src/worker.ts Outdated Show resolved Hide resolved
packages/xeus/src/worker.ts Outdated Show resolved Hide resolved
packages/xeus/src/worker.ts Outdated Show resolved Hide resolved
@martinRenou martinRenou added the enhancement New feature or request label Dec 17, 2024
@martinRenou martinRenou changed the title Add mambajs Bootstrap environments using mambajs, allowing libraries handling for other kernels than xeus-python Dec 17, 2024
@martinRenou
Copy link
Member

@AnastasiaSliusar it seems you need to run jlpm and commit the yarn.lock

@AnastasiaSliusar AnastasiaSliusar marked this pull request as ready for review December 17, 2024 14:15
martinRenou
martinRenou approved these changes Dec 17, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thanks!

@martinRenou martinRenou merged commit 8ad7f33 into jupyterlite:main Dec 17, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnastasiaSliusar @martinRenou