-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(relay): add trait based implementation for relay #7264
Open
ShankarSinghC
wants to merge
8
commits into
main
Choose a base branch
from
relay/trait-impl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+261
−118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed Files
|
jarnura
requested changes
Feb 13, 2025
crates/router/src/core/relay.rs
Outdated
@@ -17,13 +21,222 @@ use crate::{ | |||
|
|||
pub mod utils; | |||
|
|||
pub async fn relay( | |||
pub trait Validate { | |||
type Error; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add Context here itself.
jarnura
previously approved these changes
Feb 14, 2025
sai-harsha-vardhan
approved these changes
Feb 20, 2025
jarnura
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-refactor
Category: Refactor
M-api-contract-changes
Metadata: This PR involves API contract changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This pr refactors the relay flow to add trait based implementation for it.
Changes made:-
relay_flow_decider
decides the relay flow based on the relay typesRelayInterface
trait that consists the methods required for different relay typesa.
validate_relay_request
validates the relay requests for different type of relay types. It also provides defaultimplementation, if a new relay type does not have specific type.
b.
get_domain_models
to convert the relay request form api models to domain modelsc.
process_relay
that consists the core functionality for every relay typed.
generate_response
relay type specific responseValidate
trait provides the generic validation. This trait can be implemented for any type, that requires validation.Additional Changes
Motivation and Context
How did you test it?
-> Make a relay payment
Checklist
cargo +nightly fmt --all
cargo clippy