Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(connector): add template code for recurly #7284

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(connector): add template code for recurly #7284

wants to merge 4 commits into from

Conversation

aniketburman014
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

connector integration template code for recurly.

Issue: This PR closes the issue #7283

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

No testing required since its a template code

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@aniketburman014 aniketburman014 added the A-connector-integration Area: Connector integration label Feb 17, 2025
@aniketburman014 aniketburman014 self-assigned this Feb 17, 2025
@aniketburman014 aniketburman014 requested review from a team as code owners February 17, 2025 11:09
@semanticdiff-com SemanticDiff.com
Copy link

semanticdiff-com bot commented Feb 17, 2025 •
edited
Loading

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/connector.rs  83% smaller
  crates/hyperswitch_connectors/src/connectors.rs  36% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  16% smaller
  crates/router/src/core/payments/flows.rs  16% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  15% smaller
  crates/hyperswitch_connectors/src/default_implementations_v2.rs  15% smaller
  config/config.example.toml Unsupported file format
  config/deployments/integration_test.toml Unsupported file format
  config/deployments/production.toml Unsupported file format
  config/deployments/sandbox.toml Unsupported file format
  config/development.toml Unsupported file format
  config/docker_compose.toml Unsupported file format
  crates/common_enums/src/connector_enums.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/recurly.rs  0% smaller
  crates/hyperswitch_connectors/src/connectors/recurly/transformers.rs  0% smaller
  crates/hyperswitch_interfaces/src/configs.rs  0% smaller
  crates/router/src/types/api.rs  0% smaller
  crates/router/src/types/transformers.rs  0% smaller
  crates/router/tests/connectors/main.rs  0% smaller
  crates/router/tests/connectors/recurly.rs  0% smaller
  crates/router/tests/connectors/sample_auth.toml Unsupported file format
  crates/test_utils/src/connector_auth.rs  0% smaller
  loadtest/config/development.toml Unsupported file format
  scripts/add_connector.sh Unsupported file format

@aniketburman014 aniketburman014 linked an issue Feb 17, 2025 that may be closed by this pull request
feat(connector): add template code for recurly #7283
Open
srujanchikke
srujanchikke requested changes Feb 17, 2025
View reviewed changes
crates/hyperswitch_connectors/src/connectors/recurly/test.rs Outdated
@@ -0,0 +1,402 @@
use masking::Secret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can delete this file.

crates/router/tests/connectors/recurly.rs
@@ -0,0 +1,421 @@
use hyperswitch_domain_models::payment_method_data::{Card, PaymentMethodData};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this file present in both the crates, hyperswitch_connectors and router ?

srujanchikke
srujanchikke previously approved these changes Feb 17, 2025
View reviewed changes
@aniketburman014 aniketburman014 changed the title add template code for recurly feat(connector):add template code for recurly Feb 18, 2025
@aniketburman014 aniketburman014 changed the title feat(connector):add template code for recurly feat(connector): add template code for recurly Feb 18, 2025
srujanchikke
srujanchikke reviewed Feb 18, 2025
View reviewed changes
config/deployments/integration_test.toml Outdated
@@ -99,6 +99,7 @@ powertranz.base_url = "https://staging.ptranz.com/api/"
prophetpay.base_url = "https://ccm-thirdparty.cps.golf/"
rapyd.base_url = "https://sandboxapi.rapyd.net"
razorpay.base_url = "https://sandbox.juspay.in/"
recurly.base_url = "https://$.recurly.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
recurly.base_url = "https://$.recurly.com"
recurly.base_url = "https://{{merchant_site_name}}.recurly.com"

Can you make the same changes in all other places ?

@likhinbopanna likhinbopanna added this pull request to the merge queue Feb 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarnura jarnura jarnura approved these changes

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@srujanchikke srujanchikke srujanchikke approved these changes

Assignees

@aniketburman014 aniketburman014

Labels
A-connector-integration Area: Connector integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(connector): add template code for recurly
4 participants
@aniketburman014 @jarnura @SanchithHegde @srujanchikke