Merge pull request #58 from irsyadadl/bump

fix tests

.env.example

@@ -3,7 +3,7 @@ APP_ENV=local
 APP_KEY=
 APP_DEBUG=true
 APP_TIMEZONE=UTC
-APP_URL=http://localhost
+APP_URL=http://inertia.ts.test
 
 APP_LOCALE=en
 APP_FALLBACK_LOCALE=en

database/factories/UserFactory.php

@@ -24,6 +24,7 @@ class UserFactory extends Factory
     public function definition(): array
     {
         return [
+            'username' => fake()->userName(),
             'name' => fake()->name(),
             'email' => fake()->unique()->safeEmail(),
             'email_verified_at' => now(),

database/migrations/0001_01_01_000000_create_users_table.php

@@ -12,6 +12,7 @@ public function up(): void
             $table->id();
             $table->string('name');
             $table->string('email')->unique();
+            $table->string('username')->unique()->nullable();
             $table->timestamp('email_verified_at')->nullable();
             $table->string('password');
             $table->rememberToken();

tests/Feature/Auth/AuthenticationTest.php

@@ -1,7 +1,6 @@
 <?php
 
 use App\Models\User;
-use App\Providers\RouteServiceProvider;
 
 test('login screen can be rendered', function () {
     $response = $this->get('/login');
@@ -18,7 +17,7 @@
     ]);
 
     $this->assertAuthenticated();
-    $response->assertRedirect(RouteServiceProvider::HOME);
+    $response->assertRedirect(route('dashboard', absolute: false));
 });
 
 test('users can not authenticate with invalid password', function () {
@@ -31,3 +30,12 @@
 
     $this->assertGuest();
 });
+
+test('users can logout', function () {
+    $user = User::factory()->create();
+
+    $response = $this->actingAs($user)->post('/logout');
+
+    $this->assertGuest();
+    $response->assertRedirect('/');
+});

tests/Feature/Auth/EmailVerificationTest.php

@@ -1,25 +1,20 @@
 <?php
 
 use App\Models\User;
-use App\Providers\RouteServiceProvider;
 use Illuminate\Auth\Events\Verified;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\URL;
 
 test('email verification screen can be rendered', function () {
-    $user = User::factory()->create([
-        'email_verified_at' => null,
-    ]);
+    $user = User::factory()->unverified()->create();
 
     $response = $this->actingAs($user)->get('/verify-email');
 
     $response->assertStatus(200);
 });
 
 test('email can be verified', function () {
-    $user = User::factory()->create([
-        'email_verified_at' => null,
-    ]);
+    $user = User::factory()->unverified()->create();
 
     Event::fake();
 
@@ -33,13 +28,11 @@
 
     Event::assertDispatched(Verified::class);
     expect($user->fresh()->hasVerifiedEmail())->toBeTrue();
-    $response->assertRedirect(RouteServiceProvider::HOME . '?verified=1');
+    $response->assertRedirect(route('dashboard', absolute: false).'?verified=1');
 });
 
 test('email is not verified with invalid hash', function () {
-    $user = User::factory()->create([
-        'email_verified_at' => null,
-    ]);
+    $user = User::factory()->unverified()->create();
 
     $verificationUrl = URL::temporarySignedRoute(
         'verification.verify',

tests/Feature/Auth/PasswordResetTest.php

@@ -28,7 +28,7 @@
     $this->post('/forgot-password', ['email' => $user->email]);
 
     Notification::assertSentTo($user, ResetPassword::class, function ($notification) {
-        $response = $this->get('/reset-password/' . $notification->token);
+        $response = $this->get('/reset-password/'.$notification->token);
 
         $response->assertStatus(200);
 
@@ -51,7 +51,9 @@
             'password_confirmation' => 'password',
         ]);
 
-        $response->assertSessionHasNoErrors();
+        $response
+            ->assertSessionHasNoErrors()
+            ->assertRedirect(route('login'));
 
         return true;
     });

tests/Feature/Auth/RegistrationTest.php

@@ -1,7 +1,5 @@
 <?php
 
-use App\Providers\RouteServiceProvider;
-
 test('registration screen can be rendered', function () {
     $response = $this->get('/register');
 
@@ -11,12 +9,11 @@
 test('new users can register', function () {
     $response = $this->post('/register', [
         'name' => 'Test User',
-        'terms' => true,
         'email' => '[email protected]',
         'password' => 'password',
         'password_confirmation' => 'password',
     ]);
 
     $this->assertAuthenticated();
-    $response->assertRedirect(RouteServiceProvider::HOME);
+    $response->assertRedirect(route('dashboard', absolute: false));
 });

tests/Feature/ProfileTest.php

@@ -7,7 +7,7 @@
 
     $response = $this
         ->actingAs($user)
-        ->get(route('profile.edit'));
+        ->get('/profile/edit');
 
     $response->assertOk();
 });
@@ -18,7 +18,7 @@
     $response = $this
         ->actingAs($user)
         ->patch('/profile', [
-            'username' => 'testuser',
+            'username' => 'test_username',
             'name' => 'Test User',
             'email' => '[email protected]',
         ]);
@@ -39,15 +39,15 @@
 
     $response = $this
         ->actingAs($user)
-        ->patch(route('profile.update'), [
-            'username' => 'testuser',
+        ->patch('/profile', [
+            'username' => 'test_username',
             'name' => 'Test User',
             'email' => $user->email,
         ]);
 
     $response
         ->assertSessionHasNoErrors()
-        ->assertRedirect(route('profile.edit'));
+        ->assertRedirect('/profile/edit');
 
     $this->assertNotNull($user->refresh()->email_verified_at);
 });
@@ -57,7 +57,7 @@
 
     $response = $this
         ->actingAs($user)
-        ->delete(route('profile.destroy'), [
+        ->delete('/profile', [
             'password' => 'password',
         ]);
 
@@ -74,14 +74,14 @@
 
     $response = $this
         ->actingAs($user)
-        ->from(route('profile.edit'))
-        ->delete(route('profile.destroy'), [
+        ->from('/profile')
+        ->delete('/profile', [
             'password' => 'wrong-password',
         ]);
 
     $response
         ->assertSessionHasErrors('password')
-        ->assertRedirect(route('profile.edit'));
+        ->assertRedirect('/profile');
 
     $this->assertNotNull($user->fresh());
 });

tests/TestCase.php

@@ -6,5 +6,5 @@
 
 abstract class TestCase extends BaseTestCase
 {
-    use CreatesApplication;
+    //
 }