Add (rough) support for colors with transparency #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // https://github.com/dequelabs/axe-core/blob/4ef74435ac92a88c602690ac1e243c404f750d00/lib/commons/color/contrast.js#L88-L96 | ||
| // | ||
| // TODO: Attribute this properly. | ||
| var flattenColors = function (color, bg) { |
There was a problem hiding this comment.
Can replace this with Color().mix, it's just mixing the solid color with a percentage (inverse of the alpha level) of the transparent color.
|
Thanks! I am definitely interested in supporting reba/hsla colors. It might take me some time to check this out though, so just a heads up 😎 |
|
👍 I went on vacation right after opening this, so that works for me. I'll clean this up in the next couple of days + ping you when I think it's good to go. |
alexlande
force-pushed
the
alphaContrast
branch
from
c936088 to
78c8598
Compare
|
Ok, revised this. I've got it running in my pattern library now and checked the results against aXe, all seems well. Notable things:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @jxnblk! This is really rough and not tested very well (or at all), but I wanted to see if you'd be interested in this feature before I spent too much time on it. This adds support for checking contrast with rgba/hsla colors.
On a project lately we've been setting text colors using
rgbascales of white and black, and I wanted to use colorable for our pattern library, so I tried this out to see if it would work.Let me know if this would be cool and I can clean it up and make sure it works.