Skip to content

Commit

Permalink
Make unzip quiet, add FIXME comment
Browse files Browse the repository at this point in the history
Signed-off-by: Kyle Squizzato <[email protected]>
  • Loading branch information
squizzi committed Sep 17, 2024
1 parent 7ec7fca commit f43d927
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ env:

jobs:
build:
name: Build and Test
name: Build and Unit Test
runs-on: ubuntu-latest
steps:
- name: Checkout repository
Expand Down
5 changes: 1 addition & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -313,9 +313,6 @@ dev-apply: kind-deploy registry-deploy dev-push dev-deploy dev-templates
.PHONY: dev-destroy
dev-destroy: kind-undeploy registry-undeploy ## Destroy the development environment by deleting the kind cluster and local registry.

.PHONY: test-apply
test-apply: kind-deploy dev-deploy dev-templates

.PHONY: dev-mcluster-apply
dev-mcluster-apply: envsubst
@if [ $(DEV_PROVIDER) = "aws" ]; then \
Expand Down Expand Up @@ -466,7 +463,7 @@ awscli: $(AWSCLI)
$(AWSCLI): | $(LOCALBIN)
@if [ $(OS) == "linux" ]; then \
curl "https://awscli.amazonaws.com/awscli-exe-linux-$(shell uname -m)-$(AWSCLI_VERSION).zip" -o "/tmp/awscliv2.zip"; \
unzip /tmp/awscliv2.zip -d /tmp; \
unzip -qq /tmp/awscliv2.zip -d /tmp; \
/tmp/aws/install -i $(LOCALBIN)/aws-cli -b $(LOCALBIN) --update; \
fi; \
if [ $(OS) == "darwin" ]; then \
Expand Down
2 changes: 2 additions & 0 deletions test/e2e/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,8 @@ var _ = Describe("controller", Ordered, func() {
// removed, it is deleted last since it is the basis for the hosted
// cluster.
/*
FIXME(#339): This is currently disabled as the deletion of the
standalone cluster is failing due to outstanding issues.
templateBy(managedcluster.TemplateAWSStandaloneCP, "deleting the ManagedCluster")
err = standaloneDeleteFunc()
Expect(err).NotTo(HaveOccurred())
Expand Down

0 comments on commit f43d927

Please sign in to comment.