Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reenabling of the createManagement parameter check #340

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

slysunkin
Copy link
Contributor

Description

Added code for rejecting of reenabling the createManagement parameter in Management HMC spec.

Implements #245

internal/webhook/management_webhook.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook_test.go Outdated Show resolved Hide resolved
internal/webhook/management_webhook_test.go Outdated Show resolved Hide resolved
eromanova
eromanova previously approved these changes Sep 19, 2024
Copy link
Contributor

@eromanova eromanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small comment left.

internal/webhook/management_webhook_test.go Outdated Show resolved Hide resolved
@eromanova eromanova merged commit a7811fc into k0rdent:main Sep 19, 2024
3 checks passed
@slysunkin slysunkin requested a review from eromanova September 19, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants