-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mkdocs added to /docs resolves #334 #345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested the mk-docs setup on what is defined in docs/mk-docs-setup.md
and was able to get it running on my local notebook
Co-authored-by: Kyle Squizzato <[email protected]> Signed-off-by: Michael Schmid <[email protected]>
Co-authored-by: Kyle Squizzato <[email protected]> Signed-off-by: Michael Schmid <[email protected]>
Co-authored-by: Kyle Squizzato <[email protected]> Signed-off-by: Michael Schmid <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor notes on formating + possibly missing content.
@PrashantR30 can I hand over working on these review suggestions to you? I don't think @p5ntangle or myself will have time to work on this - thanks! |
Sure @Schnitzel |
Co-authored-by: Kyle Squizzato <[email protected]> Signed-off-by: Shaun O'Meara <[email protected]>
@PrashantR30 I have made the changes suggested by @a13x5. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see all suggestions were added, so all looks good
Adding Mkdocs and the basic initial setup to the docs repo.