Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EKS e2e testing #839

Merged
merged 3 commits into from
Jan 16, 2025
Merged

Add EKS e2e testing #839

merged 3 commits into from
Jan 16, 2025

Conversation

eromanova
Copy link
Contributor

@eromanova eromanova commented Dec 26, 2024

This PR introduces the following changes:

  1. Added e2e testing to verify the successful deployment of an EKS cluster
  2. Enhanced the EKS template to allow deployment of additional add-ons
  3. Configured the CSI driver add-on to be enabled by default
  4. Workaround for [bug] EKS machines are not created: ControlPlaneIsStable preflight failed #907 is applied on EKS clusters (created by e2e tests only)

E2E

E2E testing for EKS deployments is enabled by default and integrated into the AWS provider testing suite. At this time, hosted cluster deployments are not supported for EKS clusters.

Testing Scenario:

  1. Deploy an EKS cluster using the default simple configuration
  2. Apply workaround for [bug] EKS machines are not created: ControlPlaneIsStable preflight failed #907 for the MachineDeployment
  3. Verify the deployment of all related objects
  4. Verify the CSI driver
  5. Verify the CCM

P.S. The testing scenario is intentionally kept simple, avoiding complex configurations, as the overall testing strategy is currently under review and subject to potential changes.

Closes #387

@eromanova eromanova self-assigned this Dec 26, 2024
@eromanova eromanova marked this pull request as ready for review December 27, 2024 10:52
zerospiel
zerospiel previously approved these changes Dec 30, 2024
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i left an unrelated to the PR comment, could be skipped

test/e2e/provider_aws_test.go Outdated Show resolved Hide resolved
@eromanova eromanova marked this pull request as ready for review January 16, 2025 13:36
@eromanova eromanova added the test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran label Jan 16, 2025
@eromanova eromanova merged commit 005d54f into k0rdent:main Jan 16, 2025
6 of 9 checks passed
@eromanova
Copy link
Contributor Author

The PR was tested locally since e2e tests are unstable (fix: #909).

@eromanova eromanova deleted the eks-testing branch January 16, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test e2e Runs the entire provider E2E test suite, controller E2E tests are always ran
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement automated testing for EKS templates
2 participants