Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup controllers dependent on Sveltos CRDs after its provider is installed #877

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Setup controllers dependent on Sveltos CRDs after its provider is installed #877

merged 2 commits into from
Jan 15, 2025

Conversation

wahabmk
Copy link
Contributor

@wahabmk wahabmk commented Jan 9, 2025 •
edited
Loading

Description

Moved setup for ClusterDeployment and MultiClusterService controllers after Sveltos provider is installed.

Verification

The logs no longer have the error:

2024-12-27T13:12:03Z ERROR controller-runtime.source.EventHandler if kind is a CRD, it should be installed before calling Start {"kind": "ClusterSummary.config.projectsveltos.io", "error": "no matches for kind \"ClusterSummary\" in version \"config.projectsveltos.io/v1beta1\""}

@wahabmk wahabmk force-pushed the watch-sveltos-bug branch from 42a91a1 to 5f1883f Compare January 9, 2025 16:18
@wahabmk wahabmk self-assigned this Jan 9, 2025
@wahabmk wahabmk linked an issue Jan 9, 2025 that may be closed by this pull request
HMC Installation Fails on Provisioned Cluster Due to Missing Sveltos Resources and CRDs #847
Closed
@wahabmk wahabmk marked this pull request as ready for review January 9, 2025 16:36
@wahabmk wahabmk requested review from BROngineer and gmlexx January 9, 2025 16:36
@wahabmk wahabmk changed the title Setup controllers depending on Sveltos CRDs after Sveltos provider is installed Setup controllers dependent on Sveltos CRDs after its provider is installed Jan 9, 2025
zerospiel
zerospiel reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@zerospiel zerospiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the approach looks good considering we cannot manually install the required crd beforehand somewhere in the setup section which is not an option here

internal/controller/management_controller.go Outdated Show resolved Hide resolved
internal/controller/management_controller.go Outdated Show resolved Hide resolved
internal/controller/management_controller.go Outdated Show resolved Hide resolved
@wahabmk wahabmk force-pushed the watch-sveltos-bug branch 3 times, most recently from 6226c15 to 1fd6288 Compare January 13, 2025 15:07
s3rj1k
s3rj1k suggested changes Jan 13, 2025
View reviewed changes
internal/controller/management_controller.go Outdated Show resolved Hide resolved
internal/controller/management_controller.go Outdated Show resolved Hide resolved
@wahabmk wahabmk requested a review from eromanova as a code owner January 14, 2025 11:40
@wahabmk wahabmk force-pushed the watch-sveltos-bug branch 2 times, most recently from 02bd067 to 90f61ab Compare January 14, 2025 13:39
@wahabmk wahabmk requested review from s3rj1k and zerospiel January 14, 2025 14:49
zerospiel
zerospiel previously approved these changes Jan 14, 2025
View reviewed changes
@wahabmk wahabmk requested a review from s3rj1k January 14, 2025 20:56
@wahabmk wahabmk requested a review from zerospiel January 14, 2025 21:36
@zerospiel zerospiel merged commit 2007ea1 into k0rdent:main Jan 15, 2025
5 checks passed
@wahabmk wahabmk deleted the watch-sveltos-bug branch January 15, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s3rj1k s3rj1k s3rj1k approved these changes

@zerospiel zerospiel zerospiel approved these changes

@Kshatrix Kshatrix Awaiting requested review from Kshatrix Kshatrix is a code owner

@a13x5 a13x5 Awaiting requested review from a13x5 a13x5 is a code owner

@BROngineer BROngineer Awaiting requested review from BROngineer

@gmlexx gmlexx Awaiting requested review from gmlexx

@eromanova eromanova Awaiting requested review from eromanova eromanova is a code owner

Assignees

@wahabmk wahabmk

Labels
None yet
Projects
k0rdent
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HMC Installation Fails on Provisioned Cluster Due to Missing Sveltos Resources and CRDs
3 participants
@wahabmk @zerospiel @s3rj1k