move projectsveltos crds into kcm chart #949
Merged
+15,773
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BROngineer
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
BROngineer
force-pushed
the
fix/move-sveltos-crd-to-separate-chart
branch
from
d06fa1c to
7880a61
Compare
zerospiel
previously approved these changes
Jan 27, 2025
BROngineer
force-pushed
the
fix/move-sveltos-crd-to-separate-chart
branch
from
7880a61 to
02ac3bf
Compare
Kshatrix
reviewed
Jan 27, 2025
BROngineer
force-pushed
the
fix/move-sveltos-crd-to-separate-chart
branch
from
02ac3bf to
8d9c089
Compare
Signed-off-by: Artem Bortnikov <[email protected]>
Signed-off-by: Artem Bortnikov <[email protected]>
BROngineer
force-pushed
the
fix/move-sveltos-crd-to-separate-chart
branch
from
c6b7bac to
288f0df
Compare
BROngineer
changed the title
Kshatrix
reviewed
Jan 30, 2025
| @@ -0,0 +1,9 @@ | |||
| {{- range $path, $_ := .Files.Glob "projectsveltos-crds/*.yaml" }} | |||
There was a problem hiding this comment.
please add an option to disable sveltos crds creation
|
We'd also need to keep those CRDs in sync with our currently used sveltos version (have a make target for that). could be added later though. |
Signed-off-by: Artem Bortnikov <[email protected]>
Kshatrix
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #916