Expose configuration options for Openstack volumes in the template #967
Conversation
MirgDenis
requested review from
Kshatrix,
eromanova,
a13x5 and
zerospiel
as code owners
|
JFYI this patch solves #965 |
|
@MirgDenis do you want to add example config to config/dev/openstack-clusterdeployment.yaml ? Also, you might wish to update the k0rdent docs with the new configuration and add it to the OpenStack templates in the demo repo, perhaps as an additional demo or a template on Demo1? (In the "description" for your PR, you can add "Fixes: #965") and that should link it. |
|
@wkonitzer I think it's better to examples as simple as possible. For sure we will have more options added, maybe even all keys from OpenStackMachine will be added in template, so I think no point in one more example. Commit in doc is good idea, I will prepare a patch. |
|
@MirgDenis I disagree - I want to see an example of it somewhere so I'm not having to try and figure it out from all the docs, templates etc. I already have people interested in this update, so I'd like to make it as simple as possible for them (as non-coders), to get going. If there's a decent example in the docs template, that would be enough to keep me happy. |
|
@wkonitzer undertsood. But in my opinion there are no place for for such an example. config/dev has only one simplest scenario, and docs have only API ref.
And also examples can be grouped by control/worker attribute. I think such folder is out of scope of this PR. |
* Generate templates * Bump cluster template for openstack-clusterdeployment in config/dev * Fix descriptions in worker part of schema * Add default value for new key in values.yaml
Expose rootVolume option in Openstack standalone control plane cluster template.
Resolves #965