Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: join node creates new cluster when initial etcd sync config fails #5151

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+47 −8
Draft

fix: join node creates new cluster when initial etcd sync config fails #5151

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
838e547
fix: join node creates new cluster when initial etcd sync config fails
emosbaugh Oct 23, 2024
93eb6d1
increase etcd sync config backoff
emosbaugh Nov 5, 2024
9706878
return service unavailable from k0s api when etcd is unhealthy
emosbaugh Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pkg/component/controller/etcd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ func (e *Etcd) syncEtcdConfig(ctx context.Context, etcdRequest v1beta1.EtcdReque
etcdResponse, err = e.JoinClient.JoinEtcd(ctx, etcdRequest)
return err
},
retry.Delay(1*time.Second),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain why the delay was increased in the commit message, or in a comment? If I'm not mistaken this will now block for ~ 17 minutes, whereas it was blocking only around 100 secs before?

retry.MaxJitter(1*time.Second),
retry.Context(ctx),
retry.LastErrorOnly(true),
retry.OnRetry(func(attempt uint, err error) {
Expand Down