Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear the error message of if section #292

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Make clear the error message of if section #292

merged 1 commit into from
Oct 24, 2023

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Oct 24, 2023

ref: #291

@k1LoW k1LoW self-assigned this Oct 24, 2023
@github-actions
Copy link
Contributor

Code Metrics Report

main (3431179) #292 (379039b) +/-
Coverage 66.3% 66.3% +0.0%
Code to Test Ratio 1:0.5 1:0.5 0.0
Test Execution Time 43s 45s +2s
Details
  |                     | main (3431179) | #292 (379039b) |  +/-  |
  |---------------------|----------------|----------------|-------|
+ | Coverage            |          66.3% |          66.3% | +0.0% |
  |   Files             |             31 |             31 |     0 |
  |   Lines             |           2838 |           2838 |     0 |
+ |   Covered           |           1882 |           1883 |    +1 |
  | Code to Test Ratio  |          1:0.5 |          1:0.5 |   0.0 |
  |   Code              |           7284 |           7284 |     0 |
  |   Test              |           3660 |           3660 |     0 |
- | Test Execution Time |            43s |            45s |   +2s |

Code coverage of files in pull request scope (60.2% → 60.2%)

Files Coverage +/-
config/ready.go 60.2% 0.0%

Benchmark-0 (this is custom metrics test)

main (3431179) #292 (379039b) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 676.5 ns/op 676.5 ns/op 0.0 ns/op
Metadata
main (3431179) #292 (379039b)
GOOS darwin darwin
GOARCH amd64 amd64

Benchmark-1 (this is custom metrics test)

main (3431179) #292 (379039b) +/-
Number of iterations 1500 1500 0
Nanoseconds per iteration 1345 ns/op 1345 ns/op 0 ns/op
Metadata
main (3431179) #292 (379039b)
GOOS darwin darwin
GOARCH amd64 amd64

Reported by octocov

@k1LoW k1LoW merged commit 404638c into main Oct 24, 2023
8 checks passed
@k1LoW k1LoW deleted the fix-env-error branch October 24, 2023 08:37
@github-actions github-actions bot mentioned this pull request Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant