Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path handling for Windows #315

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Fix path handling for Windows #315

merged 5 commits into from
Jan 24, 2024

Conversation

k1LoW
Copy link
Owner

@k1LoW k1LoW commented Jan 23, 2024

SSIA.

@k1LoW k1LoW self-assigned this Jan 23, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW force-pushed the windows branch 2 times, most recently from cc87d7f to 7f179de Compare January 24, 2024 00:08

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW added the bug Something isn't working label Jan 24, 2024

This comment has been minimized.

This comment has been minimized.

@k1LoW k1LoW force-pushed the windows branch 2 times, most recently from 5c00111 to aee7ca1 Compare January 24, 2024 05:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

Code Metrics Report

main (6769f96) #315 (8117fae) +/-
Coverage 66.5% 66.4% -0.1%
Code to Test Ratio 1:0.5 1:0.5 +0.0
Details
  |                    | main (6769f96) | #315 (8117fae) |  +/-  |
  |--------------------|----------------|----------------|-------|
- | Coverage           |          66.5% |          66.4% | -0.1% |
  |   Files            |             32 |             32 |     0 |
  |   Lines            |           2852 |           2843 |    -9 |
- |   Covered          |           1897 |           1888 |    -9 |
+ | Code to Test Ratio |          1:0.5 |          1:0.5 |  +0.0 |
  |   Code             |           7341 |           7329 |   -12 |
+ |   Test             |           3914 |           3993 |   +79 |

Code coverage of files in pull request scope (71.1% → 70.8%)

Files Coverage +/-
central/central.go 69.2% 0.0%
config/build.go 59.3% +1.6%
config/config.go 61.9% +0.9%
coverage/coverage.go 83.3% -1.3%
datastore/datastore.go 46.7% +0.5%
internal/path.go 83.1% -0.8%
ratio/ratio.go 92.4% +0.3%

Benchmark-0 (this is custom metrics test)

main (6769f96) #315 (8117fae) +/-
Number of iterations 1000 1000 0
Nanoseconds per iteration 676.5 ns/op 676.5 ns/op 0 ns/op
Metadata
main (6769f96) #315 (8117fae)
GOOS darwin darwin
GOARCH amd64 amd64

Benchmark-1 (this is custom metrics test)

main (6769f96) #315 (8117fae) +/-
Number of iterations 1500 1500 0
Nanoseconds per iteration 1345 ns/op 1345 ns/op 0 ns/op
Metadata
main (6769f96) #315 (8117fae)
GOOS darwin darwin
GOARCH amd64 amd64

Reported by octocov

@k1LoW k1LoW changed the title Fix for Windows Fix path handling for Windows Jan 24, 2024
@k1LoW k1LoW marked this pull request as ready for review January 24, 2024 09:26
@k1LoW k1LoW merged commit 448ec00 into main Jan 24, 2024
7 checks passed
@k1LoW k1LoW deleted the windows branch January 24, 2024 09:27
@github-actions github-actions bot mentioned this pull request Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant