Zipformer recipe for CommonVoice #1546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JinZr
changed the title
|
this PR provides support for character-based languages (mozilla lang code: yue, zh-CN, zh-TW, zh-HK, more languages to be supported), integration of word segmentation for cantonese (yue and zh-HK) using |
csukuangfj
reviewed
Apr 8, 2024
Co-authored-by: Fangjun Kuang <[email protected]>
csukuangfj
reviewed
Apr 8, 2024
| parser.add_argument( | ||
| "--subset", | ||
| type=str, | ||
| default="train", |
There was a problem hiding this comment.
Could you add a choices here? Otherwise, it is not clear what values are valid.
| # limitations under the License. | ||
|
|
||
| """ | ||
| This script takes a text file "data/lang_char/text" as input, the file consist of |
There was a problem hiding this comment.
Suggested change
| This script takes a text file "data/lang_char/text" as input, the file consist of | |
| This script takes a text file "data/lang_char/text" as input; the file consists of |
Co-authored-by: Fangjun Kuang <[email protected]>
Co-authored-by: Fangjun Kuang <[email protected]>
|
There is a bug in CommonVoice(EN) recipe（prepare.sh: line 342 ）："text" is in "supervisions", so it should be extracted by using jq '.supervisions[].text' |
|
thanks, i’ll make a pr to fix this
best regards
jin
… On Oct 9, 2024, at 14:02, wangjl ***@***.***> wrote:
There is a bug in CommonVoice(EN) recipe（prepare.sh: line 342 ）："text" is in "supervisions", so it should be extracted by using jq '.supervisions[].text'
image.png (view on web) <https://github.com/user-attachments/assets/79a319b5-bdbc-4256-8f6d-fbfd225afdb8>
—
Reply to this email directly, view it on GitHub <#1546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOON42B6TH6IMGTXINVW2QTZ2TBJDAVCNFSM6AAAAABPTXLSVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGM4DKNJVGY>.
You are receiving this because you modified the open/close state.
|
|
this pr should fix the issue, please check: #1768
thanks!
best regards
jin
… On Oct 9, 2024, at 14:02, wangjl ***@***.***> wrote:
There is a bug in CommonVoice(EN) recipe（prepare.sh: line 342 ）："text" is in "supervisions", so it should be extracted by using jq '.supervisions[].text'
image.png (view on web) <https://github.com/user-attachments/assets/79a319b5-bdbc-4256-8f6d-fbfd225afdb8>
—
Reply to this email directly, view it on GitHub <#1546 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOON42B6TH6IMGTXINVW2QTZ2TBJDAVCNFSM6AAAAABPTXLSVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBRGM4DKNJVGY>.
You are receiving this because you modified the open/close state.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.