Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lattice length #1134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glynpu
Copy link
Contributor

@glynpu glynpu commented Jan 4, 2023

A faster version of #1089

Also fix issue of results different with allow_partial=True/False with yfyeung's blank skipping model.
Results with yfyeung's model epoch-30-avg-14:

 fast_beam_search allow_partial test-clean test-other
Master code False 15.68 26.13
Master code True 7.65 17.34
Master code True(with one extra dummy frame) 5.65 15.15
This pr False 5.65 15.08
This pr True 5.65 15.08

@csukuangfj
Copy link
Collaborator

@pkufool Could you help review this PR?

@pkufool
Copy link
Collaborator

pkufool commented May 24, 2023

@pkufool Could you help review this PR?

I remember this fix can not handle streaming decoding efficiently, I already discussed this with liyong, will try adding some commits to this PR in the following week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants