Fix hotword bugs (#262)

k2-fsa · Aug 31, 2023 · 8be3e08 · 8be3e08
1 parent 401de81
commit 8be3e08
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 10 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,7 +1,7 @@
 cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
 project(sherpa-ncnn)
 
-set(SHERPA_NCNN_VERSION "2.1.0")
+set(SHERPA_NCNN_VERSION "2.1.1")
 
 # Disable warning about
 #

diff --git a/sherpa-ncnn/csrc/modified-beam-search-decoder.cc b/sherpa-ncnn/csrc/modified-beam-search-decoder.cc
@@ -251,7 +251,7 @@ void ModifiedBeamSearchDecoder::Decode(ncnn::Mat encoder_out, Stream *s,
         new_hyp.ys.push_back(new_token);
         new_hyp.num_trailing_blanks = 0;
         new_hyp.timestamps.push_back(t + frame_offset);
-        if (s != nullptr && s->GetContextGraph() != nullptr) {
+        if (s && s->GetContextGraph()) {
           auto context_res =
               s->GetContextGraph()->ForwardOneStep(context_state, new_token);
           context_score = context_res.first;

diff --git a/sherpa-ncnn/csrc/recognizer.cc b/sherpa-ncnn/csrc/recognizer.cc
@@ -172,19 +172,15 @@ class Recognizer::Impl {
   void DecodeStream(Stream *s) const {
     int32_t segment = model_->Segment();
     int32_t offset = model_->Offset();
-    bool has_context_graph = false;
 
-    if (!has_context_graph && s->GetContextGraph()) {
-      has_context_graph = true;
-    }
     ncnn::Mat features = s->GetFrames(s->GetNumProcessedFrames(), segment);
     s->GetNumProcessedFrames() += offset;
     std::vector<ncnn::Mat> states = s->GetStates();
 
     ncnn::Mat encoder_out;
     std::tie(encoder_out, states) = model_->RunEncoder(features, states);
 
-    if (has_context_graph) {
+    if (s->GetContextGraph()) {
       decoder_->Decode(encoder_out, s, &s->GetResult());
     } else {
       decoder_->Decode(encoder_out, &s->GetResult());
@@ -216,7 +212,7 @@ class Recognizer::Impl {
     }
     // Caution: We need to keep the decoder output state
     ncnn::Mat decoder_out = s->GetResult().decoder_out;
-    s->SetResult(decoder_->GetEmptyResult());
+    s->SetResult(r);
     s->GetResult().decoder_out = decoder_out;
 
     // don't reset encoder state
@@ -284,8 +280,10 @@ class Recognizer::Impl {
           int32_t number = sym_[word];
           tmp.push_back(number);
         } else {
-          NCNN_LOGE("Cannot find ID for hotword %s at line: %s", word.c_str(),
-                    line.c_str());
+          NCNN_LOGE(
+              "Cannot find ID for hotword %s at line: %s. (Hint: words on the "
+              "same line are separated by spaces)",
+              word.c_str(), line.c_str());
           exit(-1);
         }
       }