Fix releasing GIL (#741)

k2-fsa · Apr 8, 2024 · 6b3d2b8 · 6b3d2b8
1 parent 6fb8ced
commit 6b3d2b8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 12 deletions.
diff --git a/sherpa-onnx/python/csrc/offline-stream.cc b/sherpa-onnx/python/csrc/offline-stream.cc
@@ -53,17 +53,8 @@ void PybindOfflineStream(py::module *m) {
   py::class_<PyClass>(*m, "OfflineStream")
       .def(
           "accept_waveform",
-          [](PyClass &self, float sample_rate, py::array_t<float> waveform) {
-#if 0
-            auto report_gil_status = []() {
-              auto is_gil_held = false;
-              if (auto tstate = py::detail::get_thread_state_unchecked())
-                is_gil_held = (tstate == PyGILState_GetThisThreadState());
-
-              return is_gil_held ? "GIL held" : "GIL released";
-            };
-            std::cout << report_gil_status() << "\n";
-#endif
+          [](PyClass &self, float sample_rate,
+             const std::vector<float> &waveform) {
             self.AcceptWaveform(sample_rate, waveform.data(), waveform.size());
           },
           py::arg("sample_rate"), py::arg("waveform"), kAcceptWaveformUsage,

diff --git a/sherpa-onnx/python/csrc/online-stream.cc b/sherpa-onnx/python/csrc/online-stream.cc
@@ -25,7 +25,8 @@ void PybindOnlineStream(py::module *m) {
   py::class_<PyClass>(*m, "OnlineStream")
       .def(
           "accept_waveform",
-          [](PyClass &self, float sample_rate, py::array_t<float> waveform) {
+          [](PyClass &self, float sample_rate,
+             const std::vector<float> &waveform) {
             self.AcceptWaveform(sample_rate, waveform.data(), waveform.size());
           },
           py::arg("sample_rate"), py::arg("waveform"), kAcceptWaveformUsage,