Add support for AWS shared credentials file #11614
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VestigeJ
previously approved these changes
Jan 15, 2025
brandond
force-pushed
the
etcd-s3-shared-creds
branch
from
0dbaea5 to
0de71f5
Compare
brandond
force-pushed
the
etcd-s3-shared-creds
branch
from
0de71f5 to
0e86ca3
Compare
Also adds a CLI flag and fields for session token, which must be passed alongside the access key and secret when using temporary credentials. Signed-off-by: Brad Davidson <[email protected]>
brandond
force-pushed
the
etcd-s3-shared-creds
branch
from
0e86ca3 to
390f773
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11614 +/- ##
==========================================
- Coverage 50.05% 47.77% -2.29%
==========================================
Files 185 185
Lines 19265 19274 +9
==========================================
- Hits 9644 9209 -435
- Misses 8229 8734 +505
+ Partials 1392 1331 -61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Jan 16, 2025
matttrach
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add support for AWS shared credentials file
Also adds a CLI flag and fields for session token, which must be passed alongside the access key and secret when using temporary credentials. Ref: https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-envvars.html#envvars-list-AWS_SESSION_TOKEN
Types of Changes
enhancement
Verification
Use shared credentials file (
~/.aws/credentials) for S3:aws configureas rootTesting
Linked Issues
User-Facing Change
Further Comments