Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GITHUB_URL overridable #11692

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Make GITHUB_URL overridable #11692

merged 1 commit into from
Jan 30, 2025

Conversation

unguiculus
Copy link
Contributor

@unguiculus unguiculus commented Jan 30, 2025

Proposed Changes

Make GITHUB_URL in install.sh overridable.

Types of Changes

New Feature

Verification

Set GITHUB_URL. Can just be set to the default URL for testing to verify the override works. Alternatively, using a file:// URL also works.

Linked Issues

#11691

Signed-off-by: Reinhard Nägele <[email protected]>
@unguiculus unguiculus requested a review from a team as a code owner January 30, 2025 09:56
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.65%. Comparing base (0d028a2) to head (e0c3758).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11692      +/-   ##
==========================================
- Coverage   49.90%   47.65%   -2.26%     
==========================================
  Files         185      185              
  Lines       19353    19353              
==========================================
- Hits         9658     9222     -436     
- Misses       8302     8797     +495     
+ Partials     1393     1334      -59     
Flag Coverage Δ
e2etests 40.37% <ø> (-3.75%) ⬇️
inttests 35.05% <ø> (+<0.01%) ⬆️
unittests 17.03% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit a0cfc66 into k3s-io:master Jan 30, 2025
47 checks passed
@unguiculus unguiculus deleted the github-url branch January 31, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants