Skip to content

Commit

Permalink
Bump Kubevirt to v0.29.0 (#139)
Browse files Browse the repository at this point in the history
* Set kubevirt to latest version in go.mod

Signed-off-by: Or Mergi <[email protected]>

* Post 'make vendor' modified files

Signed-off-by: Or Mergi <[email protected]>

* Deploy the latest version of kubevirt

Signed-off-by: Or Mergi <[email protected]>

* Remove 'Expect' for spesific error messages

In this test we expect for a sertain error message from
the virtClient when creating a VM, this message is changed
and no longer includes 'every network must be mapped to an interface'.

Since we expect to the VM creating to fail due to not valid
request we dont need to look for spesific error message,
we will get an error from kubevirt validition webhook.

Signed-off-by: Or Mergi <[email protected]>
  • Loading branch information
ormergi authored May 12, 2020
1 parent 72b710d commit 72bdb70
Show file tree
Hide file tree
Showing 13 changed files with 956 additions and 225 deletions.
2 changes: 1 addition & 1 deletion cluster/up.sh
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ set -ex

source ./cluster/kubevirtci.sh
CNAO_VERSIOV=0.35.0
KUBEVIRT_VERSION=v0.20.4
KUBEVIRT_VERSION=v0.29.0
kubevirtci::install

if [[ "$KUBEVIRT_PROVIDER" != external ]]; then
Expand Down
9 changes: 6 additions & 3 deletions go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -3,26 +3,29 @@ module github.com/k8snetworkplumbingwg/kubemacpool
go 1.12

require (
github.com/coreos/pkg v0.0.0-20180928190104-399ea9e2e55f // indirect
github.com/go-logr/logr v0.1.0
github.com/go-logr/zapr v0.1.1 // indirect
github.com/imdario/mergo v0.3.7 // indirect
github.com/improbable-eng/thanos v0.5.0 // indirect
github.com/intel/multus-cni v0.0.0-20200316125841-bfaf22964b51
github.com/kr/pty v1.1.5 // indirect
github.com/mattn/goveralls v0.0.5
github.com/onsi/ginkgo v1.11.0
github.com/onsi/gomega v1.8.1
github.com/openshift/api v3.9.1-0.20190401220125-3a6077f1f910+incompatible // indirect
github.com/pkg/errors v0.9.1
github.com/prometheus/procfs v0.0.8 // indirect
github.com/qinqon/kube-admission-webhook v0.6.0
go.uber.org/atomic v1.4.0 // indirect
golang.org/x/time v0.0.0-20190308202827-9d24e82272b4 // indirect
k8s.io/api v0.18.2
k8s.io/apimachinery v0.18.2
k8s.io/client-go v11.0.0+incompatible
k8s.io/client-go v12.0.0+incompatible
k8s.io/code-generator v0.18.0-alpha.2
k8s.io/utils v0.0.0-20200109141947-94aeca20bf09 // indirect
kubevirt.io/client-go v0.25.0
kubevirt.io/kubevirt v0.25.0
kubevirt.io/client-go v0.29.0
kubevirt.io/kubevirt v0.29.0
sigs.k8s.io/controller-runtime v0.4.0
sigs.k8s.io/controller-tools v0.3.0
sigs.k8s.io/kustomize/kustomize/v3 v3.3.0
Expand Down
35 changes: 27 additions & 8 deletions go.sum

Large diffs are not rendered by default.

6 changes: 2 additions & 4 deletions tests/virtual_machines_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,7 @@ var _ = Describe("Virtual Machines", func() {
baseVM := vm1.DeepCopy()

err = testClient.VirtClient.Create(context.TODO(), vm1)
Expect(err).To(HaveOccurred())
Expect(strings.Contains(err.Error(), "every network must be mapped to an interface")).To(Equal(true))
Expect(err).To(HaveOccurred(), "should fail to create VM due to missing interface assignment to a network")

baseVM.Spec.Template.Spec.Domain.Devices.Interfaces = append(baseVM.Spec.Template.Spec.Domain.Devices.Interfaces, newInterface("br2", ""))

Expand All @@ -440,8 +439,7 @@ var _ = Describe("Virtual Machines", func() {
baseVM.Name = "new-vm"

err = testClient.VirtClient.Create(context.TODO(), vm1)
Expect(err).To(HaveOccurred())
Expect(strings.Contains(err.Error(), "every network must be mapped to an interface")).To(Equal(true))
Expect(err).To(HaveOccurred(), "should fail to create VM due to missing interface assignment to a network")

baseVM.Spec.Template.Spec.Domain.Devices.Interfaces = append(baseVM.Spec.Template.Spec.Domain.Devices.Interfaces, newInterface("br2", ""))

Expand Down
Loading

0 comments on commit 72bdb70

Please sign in to comment.