Skip to content

Commit

Permalink
remove disruption pod budget from kubemacpool. (#170)
Browse files Browse the repository at this point in the history
Currently kubemacpool works in a active-backup approach, where the waiting pod is in not-ready state.
This can cause conflict when performing node drain, since we have kubemapool disruption pod budget set to minimum 1 ready pods.
In order to fix this, we need to remove the disruption pod budget, and return it only after we implement active-active approach in the kubemacpool pods

Signed-off-by: Ram Lavi <[email protected]>

Co-authored-by: Ram Lavi <[email protected]>
  • Loading branch information
kubevirt-bot and RamLavi authored Jun 3, 2020
1 parent 0e2ca51 commit ebd6d3d
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 32 deletions.
10 changes: 0 additions & 10 deletions config/default/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -118,16 +118,6 @@ spec:
secretName: service

---
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
name: mac-controller-manager
spec:
minAvailable: 1
selector:
matchLabels:
control-plane: mac-controller-manager
---
apiVersion: v1
kind: Service
metadata:
Expand Down
11 changes: 0 additions & 11 deletions config/release/kubemacpool.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,3 @@ spec:
- name: tls-key-pair
secret:
secretName: kubemacpool-service
---
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
name: kubemacpool-mac-controller-manager
namespace: kubemacpool-system
spec:
minAvailable: 1
selector:
matchLabels:
control-plane: mac-controller-manager
11 changes: 0 additions & 11 deletions config/test/kubemacpool.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -320,14 +320,3 @@ spec:
- name: tls-key-pair
secret:
secretName: kubemacpool-service
---
apiVersion: policy/v1beta1
kind: PodDisruptionBudget
metadata:
name: kubemacpool-mac-controller-manager
namespace: kubemacpool-system
spec:
minAvailable: 1
selector:
matchLabels:
control-plane: mac-controller-manager

0 comments on commit ebd6d3d

Please sign in to comment.