Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golang, Bump to go 1.16.7 #332

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

RamLavi
Copy link
Member

@RamLavi RamLavi commented Aug 26, 2021

This PR bumps golang to 1.16.7

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

@RamLavi
Copy link
Member Author

RamLavi commented Aug 26, 2021

/cherry-pick release-v0.31

@kubevirt-bot
Copy link
Collaborator

@RamLavi: once the present PR merges, I will cherry-pick it on top of release-v0.31 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v0.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@ormergi ormergi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks so easy hehe..

@RamLavi
Copy link
Member Author

RamLavi commented Aug 26, 2021

did the following locally:

kubemacpool (_bump_go_1.16) $ export GOFLAGS=-mod=vendor
kubemacpool (_bump_go_1.16) $ export GO111MODULE=on
kubemacpool (_bump_go_1.16) $ go version
go version go1.16.7 linux/amd64
kubemacpool (_bump_go_1.16) $ go mod tidy
kubemacpool (_bump_go_1.16) $ go mod vendor

Copy link
Collaborator

@ormergi ormergi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it looks like a go version bump ;)

@RamLavi
Copy link
Member Author

RamLavi commented Aug 26, 2021

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@RamLavi RamLavi changed the title golang, Bump to go 1.16 golang, Bump to go 1.16.7 Aug 26, 2021
@kubevirt-bot kubevirt-bot merged commit d67f798 into k8snetworkplumbingwg:main Aug 26, 2021
@kubevirt-bot
Copy link
Collaborator

@RamLavi: new pull request created: #334

In response to this:

/cherry-pick release-v0.31

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants