Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

functest: Fix ip link command output #822

Merged

Conversation

SchSeba
Copy link
Collaborator

@SchSeba SchSeba commented Dec 24, 2024

This will fix the issue we sometime see <string>: Dump was interrupted and may be inconsistent.\n

https://docs.kernel.org/userspace-api/netlink/intro.html#dump-consistency

Copy link

Thanks for your PR,
To run vendors CIs, Maintainers can use one of:

  • /test-all: To run all tests for all vendors.
  • /test-e2e-all: To run all E2E tests for all vendors.
  • /test-e2e-nvidia-all: To run all E2E tests for NVIDIA vendor.

To skip the vendors CIs, Maintainers can use one of:

  • /skip-all: To skip all tests for all vendors.
  • /skip-e2e-all: To skip all E2E tests for all vendors.
  • /skip-e2e-nvidia-all: To skip all E2E tests for NVIDIA vendor.
    Best regards.

@coveralls
Copy link

coveralls commented Dec 24, 2024

Pull Request Test Coverage Report for Build 12482647928

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 9 unchanged lines in 2 files lost coverage.
  • Overall coverage remained the same at 47.225%

Files with Coverage Reduction New Missed Lines %
controllers/drain_controller_helper.go 4 62.14%
controllers/generic_network_controller.go 5 74.38%
Totals Coverage Status
Change from base Build 12432456295: 0.0%
Covered Lines: 7198
Relevant Lines: 15242

💛 - Coveralls

This will fix the issue we sometime see ` <string>: Dump was interrupted and may be
inconsistent.\n`

https://docs.kernel.org/userspace-api/netlink/intro.html#dump-consistency

Signed-off-by: Sebastian Sch <[email protected]>
@SchSeba SchSeba force-pushed the fix_ip_link_command_tests branch from cd7a8d6 to 260d7eb Compare December 24, 2024 14:01
Copy link
Member

@zeeke zeeke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adrianchiris adrianchiris merged commit 270d88b into k8snetworkplumbingwg:master Dec 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants