Skip to content

Commit

Permalink
Merge pull request #903 from mhutter/fix/makefile-help
Browse files Browse the repository at this point in the history
Ignore commented-out targets in `make help`
  • Loading branch information
wejdross authored Nov 10, 2023
2 parents 160e339 + 21609cc commit c5f5b56
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 8 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ MAKEFLAGS += --no-builtin-variables

.PHONY: help
help: ## Show this help
@grep -E -h '\s##\s' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'
@grep -E -h '^[^#].+\s##\s' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-20s\033[0m %s\n", $$1, $$2}'

# extensible array of targets. Modules can add target to this variable for the all-in-one target.
clean_targets := build-clean
Expand Down
7 changes: 0 additions & 7 deletions envtest/integration.mk
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,6 @@ integration-test: $(setup_envtest_bin) generate restic-integration-test-setup .e
export KUBEBUILDER_ASSETS="$$($(setup_envtest_bin) $(ENVTEST_ADDITIONAL_FLAGS) use -i -p path '$(ENVTEST_K8S_VERSION)!')" && \
go test -tags=integration -coverprofile cover.out -covermode atomic ./...

# .PHONY: integration-test
# integration-test: $(setup_envtest_bin) .envtest_crds ## Run integration tests against code
# $(setup_envtest_bin) $(ENVTEST_ADDITIONAL_FLAGS) use '$(ENVTEST_K8S_VERSION)!'
# @chmod -R +w $(go_bin)/k8s
# export KUBEBUILDER_ASSETS="$$($(setup_envtest_bin) $(ENVTEST_ADDITIONAL_FLAGS) use -i -p path '$(ENVTEST_K8S_VERSION)!')" && \
# go test -tags=integration -coverprofile cover.out -covermode atomic ./...

$(envtest_crd_dir):
@mkdir -p $@

Expand Down

0 comments on commit c5f5b56

Please sign in to comment.