Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to add annotations to the ServiceAccount #877

Merged
merged 4 commits into from
Aug 4, 2023
Merged

Ability to add annotations to the ServiceAccount #877

merged 4 commits into from
Aug 4, 2023

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Aug 4, 2023 •
edited
Loading

Summary

  • Add ability to add annotations to the k8up service account

Cleanup of: #876

Checklist

For Helm Chart changes

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • PR contains the label area:chart
  • PR contains the chart label, e.g. chart:k8up
  • Variables are documented in the values.yaml using the format required by Helm-Docs.
  • Chart Version bumped if immediate release after merging is planned
  • I have run make chart-docs
  • Link this PR to related code release or other issues.

Matti Kotsalainen added 3 commits August 4, 2023 08:38
@Kidswiss
Added service account annotations
1176710 
Signed-off-by: Matti Kotsalainen <[email protected]>
@Kidswiss
Fixed comment
dd3b9fd 
Signed-off-by: Matti Kotsalainen <[email protected]>
@Kidswiss
README update
74e3fb2 
Signed-off-by: Matti Kotsalainen <[email protected]>
@Kidswiss Kidswiss requested a review from a team as a code owner August 4, 2023 06:40
@Kidswiss Kidswiss requested review from TheBigLee and wejdross and removed request for a team August 4, 2023 06:40
@Kidswiss Kidswiss merged commit 8378a19 into master Aug 4, 2023
5 of 6 checks passed
@Kidswiss Kidswiss deleted the fix/sa-annotation branch August 4, 2023 06:53
@Kidswiss Kidswiss mentioned this pull request Aug 4, 2023
Closed
@Kidswiss Kidswiss changed the title Fix/sa annotation Ability to add annotations to the ServiceAccount Aug 4, 2023
@Kidswiss Kidswiss mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBigLee TheBigLee Awaiting requested review from TheBigLee TheBigLee is a code owner automatically assigned from k8up-io/maintainer

@wejdross wejdross Awaiting requested review from wejdross wejdross is a code owner automatically assigned from k8up-io/maintainer

Assignees
No one assigned
Labels
area:chart chart:k8up enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Kidswiss