Skip to content
This repository has been archived by the owner on Nov 28, 2022. It is now read-only.

VS Code Node.js vs Nodejs #784

Closed
jcockbain opened this issue Oct 22, 2019 · 4 comments · Fixed by eclipse-archived/codewind-installer#333 or #1759 · May be fixed by kabanero-io/codewind-templates#14
Closed

VS Code Node.js vs Nodejs #784

jcockbain opened this issue Oct 22, 2019 · 4 comments · Fixed by eclipse-archived/codewind-installer#333 or #1759 · May be fixed by kabanero-io/codewind-templates#14

Comments

@jcockbain
Copy link
Contributor

jcockbain commented Oct 22, 2019

Codewind version: latest
OS: MacOs

IDE version: latest

Question synopsis:
This is a minor nit, but at the moment we display the following the information panel for a node project. Could language and projectType be made consistent?

Screenshot 2019-10-22 at 10 45 48

@tetchel
Copy link

tetchel commented Oct 22, 2019

Node.js project type is hard-coded into vs code tools, nodejs is the language as fetched from the project info (from the template link). I would rather fix the latter because it is the one that is not correct

though the best fix would be the make the language javascript since that's the actual language

@cccanderson cccanderson added the area/vscode-ide Issue associated with the Codewind VS Code/Theia extension label Oct 23, 2019
@tetchel
Copy link

tetchel commented Nov 21, 2019

going through old issues, are we going to action this? The language has to be fixed from the portal/template side.

@jcockbain
Copy link
Contributor Author

jcockbain commented Nov 22, 2019

/assign @jcockbain

@tetchel tetchel removed the area/vscode-ide Issue associated with the Codewind VS Code/Theia extension label Jan 9, 2020
@jcockbain
Copy link
Contributor Author

jcockbain commented Jan 14, 2020

Trying to get this done now (to language=javascript). As @tetchel said, changing the field here modifies the panel for projects created from templates, and changing what's set in the cwctl type detection code does so for projects created from a local dir.

The projects are then building successfully, as its buildType mainly that matters internally. However, we do have a few places in PFE where we're still checking the language (e.g. some metrics things). Going through now and making sure we don't lose any functionality for a javascript project.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.