-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pact as a dependency #186
Conversation
We only seemed to need it for generating the richlist. This is a lot easier than I had imagined.
Oh wow, this is such a relief. This should relax our dependency resolution quite a bit while upgrading our GHC or Hackage index. Thank you for the PR! BTW, would you mind checking how much further we can slim down the |
This reverts commit 950628e.
Seems like installing |
As a measure to make non-Nix builds more stable since we're removing the freeze file.
I've just added With my latest commits, in addition to these CI builds,
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for removing the pact
dependency @emmanueldenloye, this should make chainweb-data
much easier to update in the future.
We only seemed to need it for generating the richlist. This is a lot easier than I had imagined.