Division before multiplication vulnerability added. #77
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Checklist
Describe the changes you've made:
This contribution adds a vulnerability that exploits solidity integer division which causes fractional loss due to truncation. I think we can create a new category called
Solidity Math Issues
which includes all the issues involving solidity math like divide by zero, rounding errors, rounding to 0, loss of precision, solidity truncation, etc in a single listing.Type of change
Select the appropriate checkbox:
Additional Information
I think the example I presented here is not formatted properly. Let me hear your recommendations and I will make changes accordingly.