Fix generation of URLs with a ROOT_URL containing a path #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderS
force-pushed
the
fix/url-generation-with-path
branch
from
ddab582
to
3fa8c28
Compare
|
@AliexanderS would you mind submitting this PR to FineRouter too? EDIT: @AliexanderS FineRouter has commit history. |
This was referenced Jan 23, 2017
|
Hey guys. I know what it's like to have a bunch of PRs to review and test, but if this PR fixes the problem, that solves a big issue downstream for a ton of wekan users. Any chance this will get merged anytime soon? |
|
A slightly nicer fix would be: var pathWithoutBase = completePath.replace(new RegExp('^(\/)|' + basePath), ''); |
dr-dimitru
added a commit
to veliovgroup/flow-router
that referenced
this pull request
Feb 23, 2017
- Fix generation of URLs with a ROOT_URL containing a path, see [PR kadirahq#691](kadirahq#691)
dr-dimitru
added a commit
to veliovgroup/flow-router
that referenced
this pull request
Feb 23, 2017
- Fix for cases when route's param isn't String - Fix broken redirects in triggers - Fix exception on `new Route()` without arguments - Preserve `%` and `+` symbols in URI - Allow to use triggersEnter in Group without Array, see [PR kadirahq#659](kadirahq#659) - Fix generation of URLs with a ROOT_URL containing a path, see [PR kadirahq#691](kadirahq#691) - Support RegEx ([0-9]*) in .path, see [PR kadirahq#654](kadirahq#654) - Fix nested groups on server, see [PR kadirahq#663](kadirahq#663) - Same behavior for Server groups, as for groups on Client - Add auto-tests - NPM Dependencies update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #684.
The replacement of the basePath was missing one slash and so the generated url contained a double slash and fails to match the correct route.