Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT feat: added protobuf serde based on remote files. Resolve 841 #842

Closed
wants to merge 1 commit into from

Conversation

bespaltovyj
Copy link

@bespaltovyj bespaltovyj commented Feb 15, 2025

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? Added SerDe for protobuf format with sheme loading from remote server #841.
PR is draft beause i want to discuss this decision.

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@bespaltovyj bespaltovyj requested a review from a team as a code owner February 15, 2025 14:38
@kapybro kapybro bot added status/triage Issues pending maintainers triage area/serde Serialization & Deserialization (plugins) status/triage/manual Manual triage in progress status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Feb 15, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi bespaltovyj! 👋

Welcome, and thank you for opening your first PR in the repo!

Please wait for triaging by our maintainers.

Please take a look at our contributing guide.

@bespaltovyj bespaltovyj reopened this Feb 15, 2025
@bespaltovyj bespaltovyj changed the title DRAFT feat: added protobuf serde based on remote files. Resolve 841 DRAFT feat: added protobuf serde based on remote files. Resolve #841 Feb 15, 2025
@bespaltovyj bespaltovyj changed the title DRAFT feat: added protobuf serde based on remote files. Resolve #841 DRAFT feat: added protobuf serde based on remote files. Resolve 841 Feb 15, 2025
Copy link
Member

@Haarolean Haarolean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll discuss this internally. I'm not sure we want to see this as a built-in serde, especially considering loading arbitrary resources over network

@bespaltovyj
Copy link
Author

@Haarolean After thinking about it, it also seems to me that this solution should be implemented as a separate plugin.
Thanks for your feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/serde Serialization & Deserialization (plugins) status/triage/completed Automatic triage completed status/triage/manual Manual triage in progress
Projects
Status: Active
Development

Successfully merging this pull request may close these issues.

2 participants