Skip to content

Commit

Permalink
Merge pull request #595 from zmstone/ci-update-action-version
Browse files Browse the repository at this point in the history
ci: use upload-artifacts v4 remove coveralls
  • Loading branch information
zmstone authored Sep 13, 2024
2 parents e9513f4 + cfd9df8 commit 0d106f7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 22 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,15 +72,15 @@ jobs:
make test-env
make t
- name: Store test logs
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
if: always()
with:
name: ct-logs-otp-${{matrix.otp}}-kafka-${{matrix.kafka}}
path: _build/test/logs
- name: Create Cover Reports
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: rebar3 do cover,coveralls send
run: rebar3 do cover
docs:
needs: build
runs-on: ubuntu-20.04
Expand All @@ -97,7 +97,7 @@ jobs:
- name: Build Documentation
run: rebar3 do hex build
- name: Publish documentation
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: edoc
path: doc
3 changes: 0 additions & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,5 @@ brod-cli:
cover:
@rebar3 cover -v

coveralls:
@rebar3 coveralls send

dialyzer:
@rebar3 dialyzer
2 changes: 1 addition & 1 deletion rebar.config
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{deps, [{kafka_protocol, "4.1.5"}]}.
{project_plugins, [{coveralls, "~> 2.2.0"}, {rebar3_lint, "~> 3.2.5"}]}.
{project_plugins, [{rebar3_lint, "~> 3.2.5"}]}.
{edoc_opts, [{preprocess, true}, {macros, [{build_brod_cli, true}]}]}.
{erl_opts, [warnings_as_errors, warn_unused_vars,warn_shadow_vars,warn_obsolete_guard,debug_info]}.
{xref_checks, [undefined_function_calls, undefined_functions,
Expand Down
16 changes: 1 addition & 15 deletions rebar.config.script
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,4 @@ Plugins =
{project_plugins, lists:merge(ExtraPlugins, proplists:get_value(project_plugins, CONFIG))};
_ -> {project_plugins, proplists:get_value(project_plugins, CONFIG)}
end,
CoverallsConfigs = case {os:getenv("GITHUB_ACTIONS"), os:getenv("GITHUB_TOKEN")} of
{"true", Token} when is_list(Token) ->
Configs = [{coveralls_repo_token, Token},
{coveralls_coverdata, "_build/test/cover/*.coverdata"},
{coveralls_service_job_id, os:getenv("GITHUB_RUN_ID")},
{coveralls_commit_sha, os:getenv("GITHUB_SHA")},
{coveralls_service_name, "github"},
{coveralls_service_number, os:getenv("GITHUB_RUN_NUMBER")}],
case os:getenv("GITHUB_EVENT_NAME") =:= "pull_request" andalso string:tokens(os:getenv("GITHUB_REF"), "/") of
[_, "pull", PRNO, _] -> [{coveralls_service_pull_request, PRNO} | Configs];
_ -> Configs
end;
_ -> []
end,
[Plugins | lists:merge(CoverallsConfigs, CONFIG)].
[Plugins | CONFIG].

0 comments on commit 0d106f7

Please sign in to comment.