Guard against undefined partition worker pid #581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urmastalimaa
force-pushed
the
guard_against_undefined_pid_in_get_partition_worker
branch
2 times, most recently
from
29a90eb
to
95b7eb3
Compare
urmastalimaa
force-pushed
the
guard_against_undefined_pid_in_get_partition_worker
branch
from
95b7eb3
to
ae7fba9
Compare
|
CI failing with |
urmastalimaa
force-pushed
the
guard_against_undefined_pid_in_get_partition_worker
branch
from
ae7fba9
to
3c749c6
Compare
fixed in kafka_protocol. will work on this one later. |
|
ci fix ref: kafka4beam/kafka_protocol#121 |
I've observed a data race when starting a consumer from within another consumer (using co-partitioned topics), where the call to `get_partition_worker` fails due to badarg in `is_process_alive`. It seems that 1f2290b ("Verify partition worker process is alive.", 2022-05-19) already tried to resolve the data race, but did not consider the possibility that the lookup returns `undefined`. Example exit report from Elixir logger: ``` Last message: {:EXIT, #PID<0.2613.0>, {:badarg, [{:erlang, :is_process_alive, [:undefined], [error_info: %{module: :erl_erts_errors}]}, {:brod_client, :get_partition_worker, 2, [file: ~c"/app/deps/brod/src/brod_client.erl", line: 496]}, ...MyCallChain]}} ```
urmastalimaa
force-pushed
the
guard_against_undefined_pid_in_get_partition_worker
branch
from
3c749c6
to
43f8f9c
Compare
|
fixed in #582 |
|
pulled the commits into this PR: #587 |
|
Thanks for merging 👍 |
urmastalimaa
deleted the
guard_against_undefined_pid_in_get_partition_worker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've observed a data race when starting a consumer from within another consumer (using co-partitioned topics), where the call to
get_partition_workerfails due to badarg inis_process_alive.It seems that 1f2290b ("Verify partition worker process is alive.", 2022-05-19) already tried to resolve the data race, but did not consider the possibility that the lookup returns
undefined.Example exit report from Elixir logger: