Expose Method to Pass Compression Options to Clients #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
compress/2
method to allow passing compress options to the compressionlz4b_frame
headers to theinclude
directory so clients can make use of the records to pass to compress/decompress functions.Details
The only compression method exposed to the client is
compress/1
which defaults to passing0
as thecompress_options
. Being able to pass in compression options would allow for more flexibility when using producer compression.In particular, the use case I have is to disable dependant block compression by setting
blockMode = 1
instead of0
. This is because we are seeing the following errors in our kafka brokers when attempting to uselz4
for compression: