Upgrade to lz4 1.10 and fix 4096 byte compression #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhuyan
approved these changes
Sep 21, 2024
|
@qzhuyan thanks for the review. Is there a release planned with these changes |
|
tagged 0.0.12, publishing to hex is coming soon. |
|
hex.pm is broke for me, not release on hex.pm this time. |
|
@qzhuyan if you make me a publisher, i can try to publish it. |
|
I have no permission to add publisher in hex.pm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Bug Description
@dstCapacity MUST be >= LZ4F_compressFrameBound(srcSize, preferencesPtr).However for message close to 4096 bytes, it looks like it is possible for slight expansion. Running a quick test with the message batch just under 4096: