Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks #154

Merged
merged 15 commits into from
Dec 4, 2024

Conversation

ulbqb
Copy link
Contributor

@ulbqb ulbqb commented Nov 28, 2024

Proposed changes

This PR enables Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks. This test uses [email protected] and prague-devnet-4. Version prague-devnet-4 contains only latest EIPs test of Prague so this uses latest major version and latest Prague version in combination.

core change:
This fixes to check if a called address is active precompiled contract during evm execution in test. This test needs precise check for active precompiled contracts.

skip tests:

  • cancun/eip4788_beacon_root/* - This isn't supported yet.
  • cancun/eip4844_blobs/* - This isn't supported yet.
  • prague/eip7702_set_code_tx/* - This isn't supported yet.
  • prague/eip2537_bls_12_381_precompiles/bls12_precompiles_before_fork/precompile_before_fork.json - This is check that old fork doesn't activate the precompiled contracts of EIP-2537. But Kaia recognizes 0x0a and 0x0b as precompiled contracts after Istanbul. This behavior results in the different consumed gas because two addresses are set in access list during tx preparation.

related: #152

Types of changes

Please put an x in the boxes related to your change.

  • Bugfix
  • New feature or enhancement
  • Others

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING GUIDELINES doc
  • I have read the CLA and signed by comment I have read the CLA Document and I hereby sign the CLA in first time contribute
  • Lint and unit tests pass locally with my changes ($ make test)
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Related issues

  • Please leave the issue numbers or links related to this PR here.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@ulbqb ulbqb changed the title Enable Cancun and Prague EIPs test test: Enable Cancun and Prague EIPs test Nov 28, 2024
@ulbqb ulbqb changed the title test: Enable Cancun and Prague EIPs test test: Enable Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks Dec 2, 2024
@ulbqb ulbqb marked this pull request as ready for review December 2, 2024 07:32
@ulbqb ulbqb self-assigned this Dec 2, 2024
@Mdaiki0730 Mdaiki0730 self-requested a review December 2, 2024 07:34
@ulbqb ulbqb mentioned this pull request Dec 2, 2024
31 tasks
blockchain/vm/contracts.go Outdated Show resolved Hide resolved
Copy link
Contributor

@blukat29 blukat29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ulbqb ulbqb requested a review from Mdaiki0730 December 2, 2024 08:47
build/ci.go Outdated Show resolved Hide resolved
tests/state_test.go Outdated Show resolved Hide resolved
tests/state_test_util.go Outdated Show resolved Hide resolved
build/ci.go Show resolved Hide resolved
tests/state_test_util.go Show resolved Hide resolved
@ulbqb ulbqb merged commit bcb8faf into kaiachain:dev Dec 4, 2024
11 checks passed
@ulbqb ulbqb deleted the feat/add_cancun_test branch December 4, 2024 01:11
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants