-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Enable Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ulbqb
changed the title
Enable Cancun and Prague EIPs test
test: Enable Cancun and Prague EIPs test
Nov 28, 2024
ulbqb
changed the title
test: Enable Cancun and Prague EIPs test
test: Enable Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks
Dec 2, 2024
blukat29
reviewed
Dec 2, 2024
blukat29
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Mdaiki0730
reviewed
Dec 2, 2024
ian0371
reviewed
Dec 3, 2024
Co-authored-by: Chihyun Song <[email protected]>
hyunsooda
reviewed
Dec 3, 2024
blukat29
approved these changes
Dec 3, 2024
Mdaiki0730
approved these changes
Dec 3, 2024
hyunsooda
approved these changes
Dec 3, 2024
ian0371
approved these changes
Dec 3, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR enables Shanghai, Cancun and Prague EIPs test by Cancun and Prague forks. This test uses [email protected] and prague-devnet-4. Version prague-devnet-4 contains only latest EIPs test of Prague so this uses latest major version and latest Prague version in combination.
core change:
This fixes to check if a called address is active precompiled contract during evm execution in test. This test needs precise check for active precompiled contracts.
skip tests:
cancun/eip4788_beacon_root/*
- This isn't supported yet.cancun/eip4844_blobs/*
- This isn't supported yet.prague/eip7702_set_code_tx/*
- This isn't supported yet.prague/eip2537_bls_12_381_precompiles/bls12_precompiles_before_fork/precompile_before_fork.json
- This is check that old fork doesn't activate the precompiled contracts of EIP-2537. But Kaia recognizes 0x0a and 0x0b as precompiled contracts after Istanbul. This behavior results in the different consumed gas because two addresses are set in access list during tx preparation.related: #152
Types of changes
Please put an x in the boxes related to your change.
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
I have read the CLA Document and I hereby sign the CLA
in first time contribute$ make test
)Related issues
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...