-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Update manifest and helm charts for v0.3.2 #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhuangqh
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
November 14, 2024 03:43
zhuangqh
force-pushed
the
release-v0.3.2
branch
from
November 14, 2024 04:09
729932a
to
bdf79cc
Compare
zhuangqh
force-pushed
the
release-v0.3.2
branch
from
November 14, 2024 04:31
bdf79cc
to
3639839
Compare
Fei-Guo
approved these changes
Nov 14, 2024
bangqipropel
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
**Reason for Change**: <!-- What does this PR improve or fix in Kaito? Why is it needed? --> ignore instanceType when selecting preferred nodes **Requirements** - [x] added unit tests and e2e tests (if applicable). **Issue Fixed**: <!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next line. --> **Notes for Reviewers**: --------- Signed-off-by: jerryzhuang <[email protected]>
**Reason for Change**: Update links in Phi-3 readme to valid examples --------- Signed-off-by: Ishaan Sehgal <[email protected]> Signed-off-by: ishaansehgal99 <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
Signed-off-by: jerryzhuang <[email protected]>
zhuangqh
force-pushed
the
release-v0.3.2
branch
from
November 14, 2024 22:58
3639839
to
814f59e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
release v0.3.2