Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update testing GitHub Action to check for differences in poetry.lock #26

Open
ekarademir opened this issue May 31, 2020 · 0 comments
Open
Labels
good first issue Good for newcomers testing Testing enhancements

Comments

@ekarademir
Copy link
Collaborator

It is easy to forget to update poetry.lock file after changing something in the pyproject.toml file. There should be a step in testing workflow that

  1. Gets a hash of the lock file right after the checkout and saves into an environment variable
  2. Runs poetry update
  3. Gets the hash again and compares with the previous hash
  4. If results are different, then breaks the workflow.

Acceptance Criteria

  • Steps to verify correctness of poetry.lock file is added to testing GitHub Action
@ekarademir ekarademir added good first issue Good for newcomers testing Testing enhancements labels May 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Testing enhancements
Projects
None yet
Development

No branches or pull requests

1 participant