Test: N+1 발생

kakao-tech-campus-2nd-step3 · Nov 14, 2024 · da7dadd · da7dadd
1 parent 7cdea4d
commit da7dadd
Show file tree

Hide file tree

Showing 7 changed files with 428 additions and 372 deletions.
diff --git a/src/main/java/supernova/whokie/profile/ProfileVisitCount.java b/src/main/java/supernova/whokie/profile/ProfileVisitCount.java
@@ -25,6 +25,10 @@ public Long getHostId() {
         return hostId;
     }
 
+    public void add() {
+        dailyVisited++;
+    }
+
     public int getDailyVisited() {
         return dailyVisited;
     }

diff --git a/...ain/java/supernova/whokie/profile/infrastructure/repository/ProfileVisitorRepository.java b/...ain/java/supernova/whokie/profile/infrastructure/repository/ProfileVisitorRepository.java
@@ -10,4 +10,6 @@ public interface ProfileVisitorRepository extends JpaRepository<ProfileVisitor,
     boolean existsByHostIdAndVisitorIpAndModifiedAtBetween(
             Long hostId, String visitorIp, LocalDateTime start, LocalDateTime end
     );
+
+    boolean existsByHostIdAndVisitorIp(Long hostId, String visitorIp);
 }
diff --git a/src/main/java/supernova/whokie/profile/service/ProfileVisitReadService.java b/src/main/java/supernova/whokie/profile/service/ProfileVisitReadService.java
@@ -24,4 +24,11 @@ public RedisCommand.Visited findVisitCountById(Long hostId) {
         return RedisCommand.Visited.from(visitCount);
     }
 
+
+    @Transactional(readOnly = true)
+    public ProfileVisitCount findVisitCountBasdayId(Long hostId) {
+        return profileVisitCountRepository.findByHostId(hostId)
+                .orElseThrow(
+                        () -> new EntityNotFoundException(MessageConstants.USER_NOT_FOUND_MESSAGE));
+    }
 }
diff --git a/src/main/java/supernova/whokie/profile/service/ProfileWriterService.java b/src/main/java/supernova/whokie/profile/service/ProfileWriterService.java
@@ -4,15 +4,24 @@
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 import supernova.whokie.profile.Profile;
+import supernova.whokie.profile.ProfileVisitor;
 import supernova.whokie.profile.constants.ProfileConstants;
 import supernova.whokie.profile.infrastructure.repository.ProfileRepository;
+import supernova.whokie.profile.infrastructure.repository.ProfileVisitCountRepository;
+import supernova.whokie.profile.infrastructure.repository.ProfileVisitorRepository;
+import supernova.whokie.redis.entity.RedisVisitCount;
 import supernova.whokie.user.Users;
 
+import java.time.LocalDateTime;
+
 @RequiredArgsConstructor
 @Service
 public class ProfileWriterService {
 
     private final ProfileRepository profileRepository;
+    private final ProfileVisitReadService profileVisitReadService;
+    private final ProfileVisitorRepository profileVisitorRepository;
+    private final ProfileVisitCountRepository profileVisitCountRepository;
 
     @Transactional
     public void saveFromKaKao(Users user) {
@@ -23,4 +32,25 @@ public void saveFromKaKao(Users user) {
         profileRepository.save(profile);
     }
 
+    @Transactional
+    public RedisVisitCount fdsfs(Long hostId, String visitorIp) {
+        var profileVisitCount = profileVisitReadService.findVisitCountBasdayId(hostId);
+
+        if (profileVisitorRepository.existsByHostIdAndVisitorIp(hostId, visitorIp)) {
+            profileVisitCount.add();
+            profileVisitCountRepository.save(profileVisitCount);
+        }
+        profileVisitorRepository.save(ProfileVisitor.builder()
+                        .visitorIp(visitorIp)
+                        .hostId(hostId)
+                        .visitTime(LocalDateTime.now())
+                .build());
+
+        return RedisVisitCount.builder()
+                .hostId(hostId)
+                .dailyVisited(profileVisitCount.getDailyVisited())
+                .totalVisited(profileVisitCount.getTotalVisited())
+                .build();
+    }
+
 }
diff --git a/src/main/java/supernova/whokie/redis/service/RedisVisitService.java b/src/main/java/supernova/whokie/redis/service/RedisVisitService.java
@@ -7,7 +7,12 @@
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 import supernova.whokie.global.annotation.RedissonLock;
+import supernova.whokie.profile.ProfileVisitCount;
+import supernova.whokie.profile.infrastructure.repository.ProfileVisitCountRepository;
+import supernova.whokie.profile.infrastructure.repository.ProfileVisitorRepository;
 import supernova.whokie.profile.service.ProfileVisitReadService;
+import supernova.whokie.profile.service.ProfileVisitWriterService;
+import supernova.whokie.profile.service.ProfileWriterService;
 import supernova.whokie.redis.entity.RedisVisitCount;
 import supernova.whokie.redis.entity.RedisVisitor;
 import supernova.whokie.redis.infrastructure.repository.RedisVisitCountRepository;
@@ -22,17 +27,25 @@ public class RedisVisitService {
     private final RedisVisitorRepository redisVisitorRepository;
     private final RedisVisitCountRepository redisVisitCountRepository;
     private final ProfileVisitReadService profileVisitReadService;
+    private final ProfileVisitorRepository profileVisitorRepository;
+    private final ProfileVisitCountRepository profileVisitCountRepository;
+    private final ProfileWriterService profileWriterService;
 
     @RedissonLock(value = "#hostId")
     public RedisVisitCount visitProfile(Long hostId, String visitorIp) {
-        RedisVisitCount redisVisitCount = findVisitCountByHostId(hostId);
-        log.info("visitorIp: {}", visitorIp);
-        if(!checkVisited(hostId, visitorIp)) {
-            redisVisitCount.visit();
-            redisVisitCountRepository.save(redisVisitCount);
-        }
-        // 방문자 로그 기록
-        saveVisitor(hostId, visitorIp);
+//        RedisVisitCount redisVisitCount = findVisitCountByHostId(hostId);
+//        log.info("visitorIp: {}", visitorIp);
+//        if(!checkVisited(hostId, visitorIp)) {
+//            redisVisitCount.visit();
+//            redisVisitCountRepository.save(redisVisitCount);
+//        }
+//        // 방문자 로그 기록
+//        saveVisitor(hostId, visitorIp);
+
+        var redisVisitCount = profileWriterService.fdsfs(hostId, visitorIp);
+
+
+
 
         return redisVisitCount;
     }