Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add missing tests for proto/snpb.(LogStreamUncommitReport) #917

Merged
merged 2 commits into from
Feb 3, 2025

Conversation

ijsong
Copy link
Member

@ijsong ijsong commented Nov 22, 2024

What this PR does

This PR adds missing tests for proto/snpb.(LogStreamUncommitReport).

@ijsong ijsong requested a review from hungryjang as a code owner November 22, 2024 09:36
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.05%. Comparing base (b6fb11e) to head (92511a1).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
+ Coverage   79.02%   79.05%   +0.03%     
==========================================
  Files         180      180              
  Lines       21621    21621              
==========================================
+ Hits        17085    17092       +7     
+ Misses       3719     3715       -4     
+ Partials      817      814       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from e92b816 to a0f2401 Compare December 13, 2024 01:52
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from 099dbf1 to fe756d5 Compare December 13, 2024 01:53
@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from a0f2401 to 36e61c6 Compare December 13, 2024 02:01
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from fe756d5 to 0060a81 Compare December 13, 2024 02:01
@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from 36e61c6 to 49cf0b6 Compare January 16, 2025 04:19
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from 0060a81 to ba94afb Compare January 16, 2025 04:19
@ijsong ijsong force-pushed the tests_validate_topic_logstream branch from 49cf0b6 to 2cdc519 Compare February 3, 2025 10:57
@ijsong ijsong force-pushed the tests_log_stream_uncommit_report branch from ba94afb to 92511a1 Compare February 3, 2025 10:57
Base automatically changed from tests_validate_topic_logstream to main February 3, 2025 11:21
@ijsong ijsong merged commit 00e2d24 into main Feb 3, 2025
10 checks passed
@ijsong ijsong deleted the tests_log_stream_uncommit_report branch February 3, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants