test(proto): add comments and tests for SyncPosition and SyncRange #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 79.08% 79.08%
=======================================
Files 180 180
Lines 21615 21615
=======================================
Hits 17094 17094
+ Misses 3711 3703 -8
- Partials 810 818 +8 ☔ View full report in Codecov by Sentry. |
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
2f9a7c7 to
4c8ea0a
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
4499f90 to
9ab27cb
Compare
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
4c8ea0a to
b189424
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
9ab27cb to
c734a48
Compare
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
b189424 to
f86dca4
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
c734a48 to
21de96f
Compare
hungryjang
approved these changes
Feb 1, 2025
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
f86dca4 to
05242b5
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
21de96f to
954578f
Compare
- Add tests for StorageNodeMetadataDescriptor and LogStreamReplicaMetadataDescriptor - Test methods: ToStorageNodeDescriptor, GetLogStream, Head, and Tail - Ensure proper coverage for edge cases and nil values
- Add comments for SyncPosition.InvalidSyncPosition, SyncPosition.Invalid, SyncPosition.LessThan, SyncRange.InvalidSyncRange, and SyncRange.Validate methods. - Add unit tests for SyncRange validation and invalid cases.
ijsong
force-pushed
the
unit_tests_for_metadata_descriptors
branch
from
05242b5 to
e929485
Compare
ijsong
force-pushed
the
tests_for_syncposition_and_syncrange
branch
from
954578f to
a037220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
SyncPosition.LessThan, SyncRange.InvalidSyncRange, and SyncRange.Validate
methods.